FrankChen021 commented on code in PR #20649: URL: https://github.com/apache/druid/pull/20649#discussion_r4336695811
########## docs/api-reference/supervisor-api.md: ########## @@ -2288,13 +2288,22 @@ The following table lists the properties of a supervisor spec: |`dataSchema`|Object|The schema for the indexing task to use during ingestion. See [`dataSchema`](../ingestion/ingestion-spec.md#dataschema) for more information.|Yes| |`tuningConfig`|Object|The tuning configuration object to define performance-related settings for the supervisor and indexing tasks.|No| -When you call this endpoint on an existing supervisor, the running supervisor signals its tasks to stop reading and begin publishing, exiting itself. Druid then uses the provided configuration from the request body to create a new supervisor. Druid submits a new schema while retaining existing publishing tasks and starts new tasks at the previous task offsets. -This way, you can apply configuration changes without a pause in ingestion. +When called on an existing supervisor, Druid compares the submitted spec with the running one. If the change requires a restart, the supervisor signals its tasks to stop reading and begin publishing, then exits. Druid creates a new supervisor using the submitted spec, retaining existing publishing tasks and starting new tasks from the previous task offsets. This allows configuration changes without interrupting data processing. + +Otherwise, if the spec is unchanged or only `taskCount` differs while task auto-scaling is enabled, Druid updates the stored spec without restarting the supervisor. Review Comment: [P3] Do not describe an unchanged spec as persisted **Finding:** For an unchanged submission, SupervisorManager returns modified=false before writing metadata; only an effective supported change, such as an autoscaler-owned taskCount update, is persisted without restarting. This sentence therefore misdocuments the new default's no-op behavior and conflicts with the documented modified response field. **Suggestion:** Clarify that an unchanged submission is a no-op, while only supported effective changes are persisted without restarting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
