adarshsanjeev commented on code in PR #20540:
URL: https://github.com/apache/druid/pull/20540#discussion_r4228082255
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSource.java:
##########
@@ -107,7 +110,8 @@ public S3InputSource(
@JsonProperty("properties") @Nullable S3InputSourceConfig
s3InputSourceConfig,
@JsonProperty("proxyConfig") @Nullable AWSProxyConfig awsProxyConfig,
@JsonProperty("endpointConfig") @Nullable AWSEndpointConfig
awsEndpointConfig,
- @JsonProperty("clientConfig") @Nullable AWSClientConfig awsClientConfig
+ @JsonProperty("clientConfig") @Nullable AWSClientConfig awsClientConfig,
+ @JacksonInject @Nullable S3IntermediateRoleConfig intermediateRoleConfig
Review Comment:
I was considering reusing `AWSCredentialsConfig`, but it's wasn't clear to
me since it is not actually injected into all the classes I need. I would have
to add it to places which might make it visible and, since it contains
credentials, I figured I'd keep it separate in the initial PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
