gianm opened a new pull request, #20541:
URL: https://github.com/apache/druid/pull/20541

   Addresses four problems:
   
   1) Provide PhysicalSegmentColumnInspector from PartialQueryableIndexSegment.
      Previously it was not provided, so segmentMetadata queries were not
      able to report types.
   
   2) Look at all cluster groups when determining capabilities, not just
      the first one. (They can differ in the details, like auto-determined
      type and hasMultipleValues.)
   
   3) Use the DimensionIndexer's ColumnFormat when writing columns in
      cluster groups and projections. Previously the ColumnFormat present
      at creation time was used, which could differ in details (such as
      hasMultipleValues). This caused multi-valued columns to be
      incorrectly persisted, in situations where the persist logic did
      not realize they were multi-value.
   
   4) Updates Capable.or and Capable.and to use correct 3-valued logic.
      This made certain new code simpler to write, and as far as I can
      tell, will only have positive effects on existing callers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to