github-advanced-security[bot] commented on code in PR #20538:
URL: https://github.com/apache/druid/pull/20538#discussion_r4226752513
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java:
##########
@@ -1628,6 +1630,53 @@
);
}
+ @MethodSource("provideQueryContexts")
+ @ParameterizedTest(name = "{0}")
+ public void testInnerJoinLookupWithChainedPostJoinVirtualColumns(Map<String,
Object> queryContext)
+ {
+ // JSON_VALUE of JSON_OBJECT plans into two virtual columns: "v1" reads
the joined column "j0.v", and "v0" reads
+ // only "v1". Both must be computed after the join.
+ testQuery(
+ "SELECT dim1, dim2, JSON_VALUE(JSON_OBJECT(KEY 'x' VALUE l.v),
'$.x')\n"
+ + "FROM foo\n"
+ + "INNER JOIN lookup.lookyloo l ON foo.dim2 = l.k",
+ queryContext,
+ ImmutableList.of(
+ newScanQueryBuilder()
+ .dataSource(
+ join(
+ new TableDataSource(CalciteTests.DATASOURCE1),
+ new LookupDataSource("lookyloo"),
+ "j0.",
+ equalsCondition(makeColumnExpression("dim2"),
makeColumnExpression("j0.k")),
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [CalciteTestBase.makeColumnExpression](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/12071)
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java:
##########
@@ -1628,6 +1630,53 @@
);
}
+ @MethodSource("provideQueryContexts")
+ @ParameterizedTest(name = "{0}")
+ public void testInnerJoinLookupWithChainedPostJoinVirtualColumns(Map<String,
Object> queryContext)
+ {
+ // JSON_VALUE of JSON_OBJECT plans into two virtual columns: "v1" reads
the joined column "j0.v", and "v0" reads
+ // only "v1". Both must be computed after the join.
+ testQuery(
+ "SELECT dim1, dim2, JSON_VALUE(JSON_OBJECT(KEY 'x' VALUE l.v),
'$.x')\n"
+ + "FROM foo\n"
+ + "INNER JOIN lookup.lookyloo l ON foo.dim2 = l.k",
+ queryContext,
+ ImmutableList.of(
+ newScanQueryBuilder()
+ .dataSource(
+ join(
+ new TableDataSource(CalciteTests.DATASOURCE1),
+ new LookupDataSource("lookyloo"),
+ "j0.",
+ equalsCondition(makeColumnExpression("dim2"),
makeColumnExpression("j0.k")),
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [CalciteTestBase.makeColumnExpression](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/12072)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
