zhang-arvin commented on PR #20092: URL: https://github.com/apache/druid/pull/20092#issuecomment-6051517728
@FrankChen021 Thanks — the P2 regression is fixed in 9b6dbab6. The rebuild of reset task groups was calling `generateStartingSequencesForPartitionGroup`, which issues another `retrieveDataSourceMetadata()`. The reset regression tests (`KafkaSupervisorTest` / `KinesisSupervisorTest`) use strict EasyMock mocks expecting an exact metadata-lookup count, so that extra call made them fail (`expected: 4, actual: 5`). The rebuild now reuses the `DataSourceMetadata` already read during `createNewTasks()` instead of re-reading it, so the number of coordinator lookups is identical to the pre-rebuild behaviour. While there, I also collect the affected group ids into a `Set` before rebuilding: rebuilding mutates `partitionsToReset`, so iterating its keys directly risked a `ConcurrentModificationException`, and several reset partitions can map to the same group. The CodeQL warning (deprecated `TypeFactory.constructParametrizedType`) was addressed in the previous push (0de811ff). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
