gitedmond commented on code in PR #20479:
URL: https://github.com/apache/druid/pull/20479#discussion_r4187442379
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/simulate/EmbeddedKafkaSupervisorTest.java:
##########
@@ -196,16 +217,21 @@ public void test_runSupervisor_withEmptyDimension()
final String emptyColumn = "unknownColumn";
final KafkaSupervisorSpec supervisorSpec = newKafkaSupervisor()
+ .withTuningConfig(tuningConfig ->
tuningConfig.withMaxRowsPerSegment(null))
+ .withIoConfig(ioConfig -> ioConfig.withTaskDuration(Period.minutes(1)))
.withDataSchema(
s -> s.withDimensions(
DimensionsSpec.getDefaultSchemas(List.of(emptyColumn,
COL_ITEM))
)
)
.build(dataSource, topic);
- cluster.callApi().postSupervisor(supervisorSpec);
+ submitSupervisor(supervisorSpec);
final int numRows = 100;
- kafkaServer.produceRecordsToTopic(generateRecordsForTopic(topic, numRows,
DateTimes.nowUtc()));
+ // Empty-dimension handling does not require a separate segment for every
row.
+ kafkaServer.produceRecordsToTopic(
+ generateRecordsForTopic(topic, numRows, DateTimes.of("2025-06-01"),
Period.seconds(1))
Review Comment:
Added a comment explaining that one-second steps keep all 100 records in the
same daily segment interval. Commit a06216c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
