gitedmond opened a new pull request, #20458:
URL: https://github.com/apache/druid/pull/20458

   Fixes #20445.
   
   ### Description
   
   This embedded test runs the `killSupervisors` duty every 100 ms with zero 
retention. After terminating a supervisor, it tried to read the two history 
entries before the duty deleted them. The [reported CI 
failure](https://github.com/apache/druid/actions/runs/36417528915/job/108912130738)
 was a 404 at that intermediate read.
   
   Remove the timing-dependent read. The test still verifies the initial 
supervisor history, waits for the cleanup metric to count both deleted entries, 
and checks that the history endpoint then returns 404. Tombstone behavior is 
covered by the separate supervisor and metadata tests.
   
   ### Validation
   
   - Before the change, the cited JDK 25 CI job failed at the intermediate 
history read. I did not reproduce this intermittent race locally.
   - After the change, the full `KillSupervisorsCustomDutyTest` class passed in 
four Maven reactor runs with `-Dsurefire.rerunFailingTestsCount=0`: 4/4 runs 
passed.
   - `mvn -B checkstyle:check -pl embedded-tests -DskipTests=true 
-Dweb.console.skip=true`: passed with 0 violations.
   - `git diff --check`: passed.
   
   This changes only the embedded test; no production behavior or public API 
changes.
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] updated an existing integration test to remove a timing-dependent 
assertion.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to