kdelay opened a new pull request, #20413:
URL: https://github.com/apache/druid/pull/20413

   Fixes #13220.
   
   ### Description
   
   `MomentSketchAggregatorFactory` had no `makeAggregateCombiner()`, so rollup 
ingestion that persists more than one intermediate index failed in 
`IndexMergerV9` with the UOE from the issue. The existing test never merged: 
the data rolls up to 9 rows and `maxRowCount` is 10.
   
   The combiner follows `TDigestSketchAggregatorFactory`: `reset` starts a new 
sketch with the factory's `k` and `compress`, and `fold` merges into it, never 
into the selector's object.
   
   Tests: an ingestion test with `maxRowCount` 3, and a unit test for the 
combiner. Both fail with the UOE without the fix. The module tests (29), 
checkstyle and forbiddenapis pass.
   
   #### Release note
   
   Fixed rollup ingestion with `momentSketch` metrics failing during index 
merge.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to