FrankChen021 commented on code in PR #20094:
URL: https://github.com/apache/druid/pull/20094#discussion_r4026083909


##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteArraysQueryTest.java:
##########
@@ -6998,6 +6998,67 @@ public void testUnnestWithGroupByOnExpression()
     );
   }
 
+  @DecoupledTestConfig(quidemReason = 
QuidemTestCaseReason.UNNEST_VC_USES_PROJECTED_CONSTANT)

Review Comment:
   [P1] New decoupled test has no backing .iq case
   
   **Finding:** This annotation opts the inherited test into 
DecoupledExtension's QTest path. When DecoupledPlanningCalciteArraysQueryTest 
runs, the runner resolves 
sql/src/test/quidem/org.apache.druid.sql.calcite.DecoupledPlanningCalciteArraysQueryTest/testUnnestWithGroupByOnSubquery.iq,
 but that file is absent from this PR, so QTestCase.isValidTestCaseFile() fails 
before executing the test on a clean checkout unless quidem.overwrite is 
enabled.
   
   **Suggestion:** Add and commit the matching .iq testcase with its generated 
header, results, and plans, or remove the quidemReason annotation if this case 
should not participate in decoupled QTests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to