capistrant commented on code in PR #20199:
URL: https://github.com/apache/druid/pull/20199#discussion_r3981754682
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/PrepareBalancerAndLoadQueues.java:
##########
@@ -184,20 +184,27 @@ private void collectHistoricalStats(
: RowKey.with(Dimension.TIER,
tier).and(Dimension.TIER_ALIAS, alias);
stats.add(Stats.Tier.HISTORICAL_COUNT, rowKey, historicals.size());
- long totalCapacity = 0;
long storageCapacity = 0;
+ long cacheCapacity = 0;
+ long cacheUsed = 0;
long cloneCount = 0;
for (ServerHolder holder : historicals) {
if (holder.isUnmanaged()) {
cloneCount += 1;
} else {
- totalCapacity += holder.getMaxSize();
- storageCapacity += holder.getStorageSize();
+ storageCapacity += holder.getMaxSize();
Review Comment:
`tier/storage/capacity` was a never documented metric. so while this is not
ideal to do... I think it is pretty harmless if documented in upgrade notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
