This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch opt_dict_perf
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/opt_dict_perf by this push:
     new d82b9c3900 [Bug](topn opt) Fix be crash when enable topn opt with 
larger thresho… (#18858) (#18987)
d82b9c3900 is described below

commit d82b9c3900b7d41e9aea974ef6f35daba9c92dd5
Author: Kang <kxiao.ti...@gmail.com>
AuthorDate: Mon Apr 24 12:24:33 2023 +0800

    [Bug](topn opt) Fix be crash when enable topn opt with larger thresho… 
(#18858) (#18987)
    
    topn opt should be inited when update it
---
 be/src/vec/exec/vsort_node.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/be/src/vec/exec/vsort_node.cpp b/be/src/vec/exec/vsort_node.cpp
index 2328393997..cd77e7d16b 100644
--- a/be/src/vec/exec/vsort_node.cpp
+++ b/be/src/vec/exec/vsort_node.cpp
@@ -58,6 +58,7 @@ Status VSortNode::init(const TPlanNode& tnode, RuntimeState* 
state) {
         _sorter.reset(new FullSorter(_vsort_exec_exprs, _limit, _offset, 
_pool, _is_asc_order,
                                      _nulls_first, row_desc, state, 
_runtime_profile.get()));
     }
+
     // init runtime predicate
     _use_topn_opt = tnode.sort_node.use_topn_opt;
     if (_use_topn_opt) {
@@ -71,8 +72,8 @@ Status VSortNode::init(const TPlanNode& tnode, RuntimeState* 
state) {
                 }
                 for (auto slot : tuple_desc->slots()) {
                     if (slot->id() == first_sort_slot.slot_id) {
-                        
RETURN_IF_ERROR(query_ctx->get_runtime_predicate().init(slot->type().type,
-                                                                               
 _nulls_first[0]));
+                        RETURN_IF_ERROR(
+                                
query_ctx->get_runtime_predicate().init(slot->type().type));
                         break;
                     }
                 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to