github-actions[bot] commented on code in PR #18541:
URL: https://github.com/apache/doris/pull/18541#discussion_r1174580322
##########
be/test/olap/tablet_schema_helper.h:
##########
@@ -42,7 +43,7 @@ TabletColumn create_with_default_value(std::string
default_value) {
TabletColumn column;
column._type = type;
Review Comment:
warning: '_type' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._type = type;
^
```
**be/src/olap/tablet_schema.h:120:** declared private here
```cpp
FieldType _type;
^
```
##########
be/test/olap/tablet_schema_helper.h:
##########
@@ -42,7 +43,7 @@
TabletColumn column;
column._type = type;
column._is_nullable = true;
Review Comment:
warning: '_is_nullable' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._is_nullable = true;
^
```
**be/src/olap/tablet_schema.h:124:** declared private here
```cpp
bool _is_nullable = false;
^
```
##########
be/test/olap/tablet_schema_helper.h:
##########
@@ -42,7 +43,7 @@
TabletColumn column;
column._type = type;
column._is_nullable = true;
- column._aggregation = OLAP_FIELD_AGGREGATION_NONE;
+ column._aggregation = FieldAggregationMethod::OLAP_FIELD_AGGREGATION_NONE;
column._has_default_value = true;
column._default_value = default_value;
column._length = 4;
Review Comment:
warning: '_length' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._length = 4;
^
```
**be/src/olap/tablet_schema.h:133:** declared private here
```cpp
int32_t _length;
^
```
##########
be/test/olap/tablet_schema_helper.h:
##########
@@ -42,7 +43,7 @@
TabletColumn column;
column._type = type;
column._is_nullable = true;
- column._aggregation = OLAP_FIELD_AGGREGATION_NONE;
+ column._aggregation = FieldAggregationMethod::OLAP_FIELD_AGGREGATION_NONE;
column._has_default_value = true;
Review Comment:
warning: '_has_default_value' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._has_default_value = true;
^
```
**be/src/olap/tablet_schema.h:126:** declared private here
```cpp
bool _has_default_value = false;
^
```
##########
be/test/olap/tablet_schema_helper.h:
##########
@@ -42,7 +43,7 @@
TabletColumn column;
column._type = type;
column._is_nullable = true;
- column._aggregation = OLAP_FIELD_AGGREGATION_NONE;
+ column._aggregation = FieldAggregationMethod::OLAP_FIELD_AGGREGATION_NONE;
Review Comment:
warning: '_aggregation' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._aggregation =
FieldAggregationMethod::OLAP_FIELD_AGGREGATION_NONE;
^
```
**be/src/olap/tablet_schema.h:122:** declared private here
```cpp
FieldAggregationMethod _aggregation;
^
```
##########
be/test/olap/tablet_schema_helper.h:
##########
@@ -42,7 +43,7 @@
TabletColumn column;
column._type = type;
column._is_nullable = true;
- column._aggregation = OLAP_FIELD_AGGREGATION_NONE;
+ column._aggregation = FieldAggregationMethod::OLAP_FIELD_AGGREGATION_NONE;
column._has_default_value = true;
column._default_value = default_value;
Review Comment:
warning: '_default_value' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._default_value = default_value;
^
```
**be/src/olap/tablet_schema.h:127:** declared private here
```cpp
std::string _default_value;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
