HappenLee commented on code in PR #18759:
URL: https://github.com/apache/doris/pull/18759#discussion_r1173251951
##########
be/src/vec/exprs/vbloom_predicate.cpp:
##########
@@ -92,10 +92,20 @@ Status VBloomPredicate::execute(VExprContext* context,
Block* block, int* result
auto ptr =
((ColumnVector<UInt8>*)res_data_column.get())->get_data().data();
auto type =
WhichDataType(remove_nullable(block->get_by_position(arguments[0]).type));
if (type.is_string_or_fixed_string()) {
- for (size_t i = 0; i < sz; i++) {
- auto ele = argument_column->get_data_at(i);
- const StringRef v(ele.data, ele.size);
- ptr[i] = _filter->find(reinterpret_cast<const void*>(&v));
+ // When _be_exec_version is equal to or greater than 2, we use the new
hash method.
+ // This is only to be used if the be_exec_version may be less than 2.
If updated, please delete it.
+ if (_be_exec_version >= 2) {
+ for (size_t i = 0; i < sz; i++) {
+ auto ele = argument_column->get_data_at(i);
Review Comment:
Add a todo here to do remove virtual function call in `get_data_at` to
improve performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
