liaoxin01 commented on code in PR #18686:
URL: https://github.com/apache/doris/pull/18686#discussion_r1172491844
##########
be/src/olap/memtable.cpp:
##########
@@ -243,11 +242,23 @@ void MemTable::_collect_vskiplist_results() {
VecTable::Iterator it(_vec_skip_list.get());
vectorized::Block in_block = _input_mutable_block.to_block();
if (_keys_type == KeysType::DUP_KEYS) {
+ vectorized::MutableBlock mutable_block =
+ vectorized::MutableBlock::build_mutable_block(&in_block);
+ _vec_row_comparator->set_block(&mutable_block);
+ std::sort(_row_in_blocks.begin(), _row_in_blocks.end(),
Review Comment:
Can we use `std::stable_sort` here directly?
`std::stable_sort(_row_in_blocks.begin(), _row_in_blocks.end(),
_vec_row_comparator);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
