amorynan commented on code in PR #18819:
URL: https://github.com/apache/doris/pull/18819#discussion_r1171978840


##########
be/src/vec/data_types/serde/data_type_array_serde.h:
##########
@@ -32,6 +33,11 @@ class DataTypeArraySerDe : public DataTypeSerDe {
         LOG(FATAL) << "Not support read from pb to array";
     }
 
+    Status write_column_to_jsonb(const IColumn& column, JsonbWriter& result, 
Arena* mem_pool,
+                                 const int32_t col_id, const int row_num) 
const override;

Review Comment:
   is const Just make others who may write other data type serde function known 
this col _id can not changed ?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to