BiteTheDDDDt commented on code in PR #18565:
URL: https://github.com/apache/doris/pull/18565#discussion_r1171071357
##########
be/src/vec/functions/function_cast.h:
##########
@@ -227,11 +314,25 @@ struct ConvertImpl {
}
}
} else {
- for (size_t i = 0; i < size; ++i) {
- vec_to[i] = static_cast<ToFieldType>(vec_from[i]);
+ if constexpr (IsDataTypeNumber<FromDataType> &&
+ std::is_same_v<ToDataType, DataTypeTime>) {
+ // 300 -> 00:03:00 360 will be parse failed , so value
maybe null
+ ColumnUInt8::MutablePtr col_null_map_to;
+ ColumnUInt8::Container* vec_null_map_to [[maybe_unused]] =
nullptr;
Review Comment:
why have maybe_unused here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
