github-actions[bot] commented on code in PR #18818: URL: https://github.com/apache/doris/pull/18818#discussion_r1171022596
########## be/src/olap/itoken_extractor.h: ########## @@ -93,6 +93,19 @@ struct NgramTokenExtractor final : public ITokenExtractorHelper<NgramTokenExtrac private: size_t n; }; + +/// Parser extracting all splits from string. +struct SplitTokenExtractor final : public ITokenExtractorHelper<SplitTokenExtractor> { +public: + SplitTokenExtractor() {} Review Comment: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] ```suggestion SplitTokenExtractor() = default; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org