freemandealer commented on code in PR #18528:
URL: https://github.com/apache/doris/pull/18528#discussion_r1162249772


##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -1107,9 +1107,10 @@ Status FileColumnIterator::_read_data_page(const 
OrdinalPageIndexIterator& iter)
                 Slice dict_data;
                 PageFooterPB dict_footer;
                 _opts.type = INDEX_PAGE;

Review Comment:
   > If index is used, is there such case that we read page number 10 first and 
then read page number 1? Or in other words, could we make sure that the data 
page is read in descending order?
   
   no sure, I will figure it out somehow



##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -1107,9 +1107,10 @@ Status FileColumnIterator::_read_data_page(const 
OrdinalPageIndexIterator& iter)
                 Slice dict_data;
                 PageFooterPB dict_footer;
                 _opts.type = INDEX_PAGE;

Review Comment:
   > If index is used, is there such case that we read page number 10 first and 
then read page number 1? Or in other words, could we make sure that the data 
page is read in descending order?
   
   not sure, I will figure it out somehow



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to