yiguolei commented on code in PR #18472:
URL: https://github.com/apache/doris/pull/18472#discussion_r1161087199
##########
be/src/exprs/block_bloom_filter.hpp:
##########
@@ -78,6 +78,13 @@ class BlockBloomFilter {
}
}
+ // This function is only to be used if the be_exec_version may be less
than 2. If updated, please delete it.
+ void insert_new_hash(const Slice& key) noexcept {
Review Comment:
do not use newxxxx, just use name like insert_crc32_hash， it will be more
clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
