github-actions[bot] commented on code in PR #18301:
URL: https://github.com/apache/doris/pull/18301#discussion_r1154508603
##########
be/test/olap/tablet_cooldown_test.cpp:
##########
@@ -377,6 +377,13 @@ void createTablet(StorageEngine* engine, TabletSharedPtr*
tablet, int64_t replic
}
TEST_F(TabletCooldownTest, normal) {
+ // loading file in remote file system would require threadpool
+ std::unique_ptr<ThreadPool> _pool;
+ ThreadPoolBuilder("BufferedReaderPrefetchThreadPool")
+ .set_min_threads(5)
+ .set_max_threads(10)
+ .build(&_pool);
+ ExecEnv::GetInstance()->_buffered_reader_prefetch_thread_pool =
std::move(_pool);
Review Comment:
warning: '_buffered_reader_prefetch_thread_pool' is a private member of
'doris::ExecEnv' [clang-diagnostic-error]
```cpp
ExecEnv::GetInstance()->_buffered_reader_prefetch_thread_pool =
std::move(_pool);
^
```
**be/src/runtime/exec_env.h:221:** declared private here
```cpp
std::unique_ptr<ThreadPool> _buffered_reader_prefetch_thread_pool;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
