This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1027abe0d3 [enhancement](query exec) should print error status when
query meet error (#18247)
1027abe0d3 is described below
commit 1027abe0d351294ef157fa2ba694dcdce7db9a3a
Author: yiguolei <676222...@qq.com>
AuthorDate: Fri Mar 31 14:08:24 2023 +0800
[enhancement](query exec) should print error status when query meet error
(#18247)
If BE is in heavy load, the query may failed, but BE will try to connect to
FE using thrift, if FE is also in heavy load the thrift connection will failed.
And the status is rewritten at line 342, and the actual failure reason for the
query is lost. Should print the error status every time during update.
Co-authored-by: yiguolei <yiguo...@gmail.com>
---
be/src/runtime/fragment_mgr.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/be/src/runtime/fragment_mgr.cpp b/be/src/runtime/fragment_mgr.cpp
index 64b84a262b..1558e9b855 100755
--- a/be/src/runtime/fragment_mgr.cpp
+++ b/be/src/runtime/fragment_mgr.cpp
@@ -110,6 +110,9 @@ public:
std::lock_guard<std::mutex> l(_status_lock);
if (!status.ok() && _exec_status.ok()) {
_exec_status = status;
+ LOG(WARNING) << "query_id=" << print_id(_query_id)
+ << ", instance_id=" << print_id(_fragment_instance_id)
+ << " meet error status " << status;
}
return _exec_status;
}
@@ -331,7 +334,6 @@ std::string FragmentMgr::to_http_path(const std::string&
file_name) {
void FragmentMgr::coordinator_callback(const ReportStatusRequest& req) {
DCHECK(req.status.ok() || req.done); // if !status.ok() => done
Status exec_status = req.update_fn(req.status);
-
Status coord_status;
FrontendServiceConnection coord(_exec_env->frontend_client_cache(),
req.coord_addr,
&coord_status);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
