yiguolei commented on code in PR #18205: URL: https://github.com/apache/doris/pull/18205#discussion_r1152664905
########## be/src/exprs/bloom_filter_func.h: ########## @@ -330,6 +330,11 @@ struct DateFindOp : public CommonFindOp<vectorized::VecDateTimeValue> { vectorized::VecDateTimeValue date_value; date_value.from_olap_date(value); + // So confusing here. For join node with condition (a.date_col = b.date_col), the actual + // expression is CAST(a.date_col AS DATETIME) = CAST(b.date_col AS DATETIME). So we build + // this bloom filter by CAST(a.date_col AS DATETIME) and also need to probe this bloom + // filter by a datetime value. + date_value.set_type(3); Review Comment: set_type(TimeType::TIME_DATETIME) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org