github-actions[bot] commented on code in PR #17820:
URL: https://github.com/apache/doris/pull/17820#discussion_r1151310671
##########
be/src/olap/predicate_creator.h:
##########
@@ -51,7 +51,7 @@ class IntegerPredicateCreator : public
PredicateCreator<ConditionType> {
public:
using CppType = typename
PredicatePrimitiveTypeTraits<Type>::PredicateFieldType;
ColumnPredicate* create(const TabletColumn& column, int index, const
ConditionType& conditions,
- bool opposite, MemPool* pool) override {
+ bool opposite, vectorized::Arena* arena) override {
if constexpr (PredicateTypeTraits::is_list(PT)) {
return create_in_list_predicate<Type, PT, ConditionType,
decltype(convert)>(
Review Comment:
warning: no matching function for call to 'create_in_list_predicate'
[clang-diagnostic-error]
```cpp
return create_in_list_predicate<Type, PT, ConditionType,
decltype(convert)>(
^
```
**/usr/include/c++/11/bits/unique_ptr.h:961:** in instantiation of member
function 'doris::IntegerPredicateCreator<doris::TYPE_TINYINT,
doris::PredicateType::IN_LIST, std::vector<std::basic_string<char>>>::create'
requested here
```cpp
{ return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
^
```
**be/src/olap/predicate_creator.h:160:** in instantiation of function
template specialization
'std::make_unique<doris::IntegerPredicateCreator<doris::TYPE_TINYINT,
doris::PredicateType::IN_LIST, std::vector<std::basic_string<char>>>>'
requested here
```cpp
return std::make_unique<IntegerPredicateCreator<TYPE_TINYINT, PT,
ConditionType>>();
^
```
**be/src/olap/predicate_creator.h:245:** in instantiation of function
template specialization 'doris::get_creator<doris::PredicateType::IN_LIST,
std::vector<std::basic_string<char>>>' requested here
```cpp
return get_creator<PT, ConditionType>(column.type())
^
```
**be/src/olap/predicate_creator.h:262:** in instantiation of function
template specialization 'doris::create_predicate<doris::PredicateType::IN_LIST,
std::vector<std::basic_string<char>>>' requested here
```cpp
return create_predicate<PT, std::vector<std::string>>(column, index,
conditions, opposite,
^
```
**be/src/olap/predicate_creator.h:290:** in instantiation of function
template specialization
'doris::create_list_predicate<doris::PredicateType::IN_LIST>' requested here
```cpp
create = create_list_predicate<PredicateType::IN_LIST>;
^
```
**be/src/olap/in_list_predicate.h:676:** candidate function template not
viable: requires at most 3 arguments, but 4 were provided
```cpp
ColumnPredicate* create_in_list_predicate(uint32_t column_id,
^
```
##########
be/src/olap/predicate_creator.h:
##########
@@ -81,7 +81,7 @@
public:
using CppType = typename
PredicatePrimitiveTypeTraits<Type>::PredicateFieldType;
ColumnPredicate* create(const TabletColumn& column, int index, const
ConditionType& conditions,
- bool opposite, MemPool* pool) override {
+ bool opposite, vectorized::Arena* arena) override {
if constexpr (PredicateTypeTraits::is_list(PT)) {
return create_in_list_predicate<Type, PT, ConditionType,
decltype(convert)>(
Review Comment:
warning: no matching function for call to 'create_in_list_predicate'
[clang-diagnostic-error]
```cpp
return create_in_list_predicate<Type, PT, ConditionType,
decltype(convert)>(
^
```
**/usr/include/c++/11/bits/unique_ptr.h:961:** in instantiation of member
function 'doris::DecimalPredicateCreator<doris::TYPE_DECIMAL32,
doris::PredicateType::IN_LIST, std::vector<std::basic_string<char>>>::create'
requested here
```cpp
{ return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
^
```
**be/src/olap/predicate_creator.h:189:** in instantiation of function
template specialization
'std::make_unique<doris::DecimalPredicateCreator<doris::TYPE_DECIMAL32,
doris::PredicateType::IN_LIST, std::vector<std::basic_string<char>>>>'
requested here
```cpp
return std::make_unique<DecimalPredicateCreator<TYPE_DECIMAL32, PT,
ConditionType>>();
^
```
**be/src/olap/predicate_creator.h:245:** in instantiation of function
template specialization 'doris::get_creator<doris::PredicateType::IN_LIST,
std::vector<std::basic_string<char>>>' requested here
```cpp
return get_creator<PT, ConditionType>(column.type())
^
```
**be/src/olap/predicate_creator.h:262:** in instantiation of function
template specialization 'doris::create_predicate<doris::PredicateType::IN_LIST,
std::vector<std::basic_string<char>>>' requested here
```cpp
return create_predicate<PT, std::vector<std::string>>(column, index,
conditions, opposite,
^
```
**be/src/olap/predicate_creator.h:290:** in instantiation of function
template specialization
'doris::create_list_predicate<doris::PredicateType::IN_LIST>' requested here
```cpp
create = create_list_predicate<PredicateType::IN_LIST>;
^
```
**be/src/olap/in_list_predicate.h:676:** candidate function template not
viable: requires at most 3 arguments, but 5 were provided
```cpp
ColumnPredicate* create_in_list_predicate(uint32_t column_id,
^
```
##########
be/src/olap/predicate_creator.h:
##########
@@ -105,26 +105,26 @@
class StringPredicateCreator : public PredicateCreator<ConditionType> {
public:
ColumnPredicate* create(const TabletColumn& column, int index, const
ConditionType& conditions,
- bool opposite, MemPool* pool) override {
+ bool opposite, vectorized::Arena* arena) override {
if constexpr (PredicateTypeTraits::is_list(PT)) {
return create_in_list_predicate<Type, PT, ConditionType,
decltype(convert)>(
Review Comment:
warning: no matching function for call to 'create_in_list_predicate'
[clang-diagnostic-error]
```cpp
return create_in_list_predicate<Type, PT, ConditionType,
decltype(convert)>(
^
```
**/usr/include/c++/11/bits/unique_ptr.h:961:** in instantiation of member
function 'doris::StringPredicateCreator<doris::TYPE_CHAR,
doris::PredicateType::IN_LIST, std::vector<std::basic_string<char>>>::create'
requested here
```cpp
{ return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
^
```
**be/src/olap/predicate_creator.h:198:** in instantiation of function
template specialization
'std::make_unique<doris::StringPredicateCreator<doris::TYPE_CHAR,
doris::PredicateType::IN_LIST, std::vector<std::basic_string<char>>>>'
requested here
```cpp
return std::make_unique<StringPredicateCreator<TYPE_CHAR, PT,
ConditionType>>();
^
```
**be/src/olap/predicate_creator.h:245:** in instantiation of function
template specialization 'doris::get_creator<doris::PredicateType::IN_LIST,
std::vector<std::basic_string<char>>>' requested here
```cpp
return get_creator<PT, ConditionType>(column.type())
^
```
**be/src/olap/predicate_creator.h:262:** in instantiation of function
template specialization 'doris::create_predicate<doris::PredicateType::IN_LIST,
std::vector<std::basic_string<char>>>' requested here
```cpp
return create_predicate<PT, std::vector<std::string>>(column, index,
conditions, opposite,
^
```
**be/src/olap/predicate_creator.h:290:** in instantiation of function
template specialization
'doris::create_list_predicate<doris::PredicateType::IN_LIST>' requested here
```cpp
create = create_list_predicate<PredicateType::IN_LIST>;
^
```
**be/src/olap/in_list_predicate.h:676:** candidate function template not
viable: requires at most 3 arguments, but 6 were provided
```cpp
ColumnPredicate* create_in_list_predicate(uint32_t column_id,
^
```
##########
be/src/olap/predicate_creator.h:
##########
@@ -140,7 +140,7 @@
: _convert(convert) {}
ColumnPredicate* create(const TabletColumn& column, int index, const
ConditionType& conditions,
- bool opposite, MemPool* pool) override {
+ bool opposite, vectorized::Arena* arena) override {
if constexpr (PredicateTypeTraits::is_list(PT)) {
return create_in_list_predicate<Type, PT, ConditionType,
decltype(_convert)>(
Review Comment:
warning: no matching function for call to 'create_in_list_predicate'
[clang-diagnostic-error]
```cpp
return create_in_list_predicate<Type, PT, ConditionType,
decltype(_convert)>(
^
```
**be/src/olap/predicate_creator.h:138:** in instantiation of member function
'doris::CustomPredicateCreator<doris::TYPE_DECIMALV2,
doris::PredicateType::IN_LIST, std::vector<std::basic_string<char>>>::create'
requested here
```cpp
CustomPredicateCreator(const std::function<CppType(const std::string&
condition)>& convert)
^
```
**/usr/include/c++/11/bits/unique_ptr.h:961:** in instantiation of member
function 'doris::CustomPredicateCreator<doris::TYPE_DECIMALV2,
doris::PredicateType::IN_LIST,
std::vector<std::basic_string<char>>>::CustomPredicateCreator' requested here
```cpp
{ return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
^
```
**be/src/olap/predicate_creator.h:181:** in instantiation of function
template specialization
'std::make_unique<doris::CustomPredicateCreator<doris::TYPE_DECIMALV2,
doris::PredicateType::IN_LIST, std::vector<std::basic_string<char>>>, (lambda
at /github/workspace/be/src/olap/predicate_creator.h:183:17)>' requested here
```cpp
return std::make_unique<CustomPredicateCreator<TYPE_DECIMALV2, PT,
ConditionType>>(
^
```
**be/src/olap/predicate_creator.h:245:** in instantiation of function
template specialization 'doris::get_creator<doris::PredicateType::IN_LIST,
std::vector<std::basic_string<char>>>' requested here
```cpp
return get_creator<PT, ConditionType>(column.type())
^
```
**be/src/olap/predicate_creator.h:262:** in instantiation of function
template specialization 'doris::create_predicate<doris::PredicateType::IN_LIST,
std::vector<std::basic_string<char>>>' requested here
```cpp
return create_predicate<PT, std::vector<std::string>>(column, index,
conditions, opposite,
^
```
**be/src/olap/predicate_creator.h:290:** in instantiation of function
template specialization
'doris::create_list_predicate<doris::PredicateType::IN_LIST>' requested here
```cpp
create = create_list_predicate<PredicateType::IN_LIST>;
^
```
**be/src/olap/in_list_predicate.h:676:** candidate function template not
viable: requires at most 3 arguments, but 4 were provided
```cpp
ColumnPredicate* create_in_list_predicate(uint32_t column_id,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
