Gabriel39 commented on code in PR #18126:
URL: https://github.com/apache/doris/pull/18126#discussion_r1149956702


##########
be/src/vec/exec/scan/scanner_context.cpp:
##########
@@ -55,8 +55,7 @@ Status ScannerContext::init() {
     // 1. Calculate max concurrency
     // TODO: now the max thread num <= 
config::doris_scanner_thread_pool_thread_num / 4
     // should find a more reasonable value.
-    _max_thread_num = _state->shared_scan_opt() ? 
config::doris_scanner_thread_pool_thread_num
-                                                : 
config::doris_scanner_thread_pool_thread_num / 4;
+    _max_thread_num = config::doris_scanner_thread_pool_thread_num / 4;

Review Comment:
   I think it's better to provide a tuning method for users (maybe add a 
configuration).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to