github-actions[bot] commented on code in PR #18009:
URL: https://github.com/apache/doris/pull/18009#discussion_r1149935090


##########
be/test/runtime/test_env.cc:
##########
@@ -35,16 +35,6 @@ TestEnv::TestEnv() {
     // TODO may need rpc support, etc.
 }
 
-void TestEnv::init_tmp_file_mgr(const std::vector<std::string>& tmp_dirs, bool 
one_dir_per_device) {
-    _tmp_file_mgr = std::make_shared<TmpFileMgr>();
-    _exec_env->_tmp_file_mgr = _tmp_file_mgr.get();
-
-    DiskInfo::init();
-    // will use DiskInfo::num_disks(), DiskInfo should be initialized before
-    auto st = _tmp_file_mgr->init_custom(tmp_dirs, one_dir_per_device);
-    EXPECT_TRUE(st.ok());
-}
-
 TestEnv::~TestEnv() {
     SAFE_DELETE(_exec_env->_result_queue_mgr);

Review Comment:
   warning: '_result_queue_mgr' is a private member of 'doris::ExecEnv' 
[clang-diagnostic-error]
   ```cpp
       SAFE_DELETE(_exec_env->_result_queue_mgr);
                              ^
   ```
   **be/src/runtime/exec_env.h:196:** declared private here
   ```cpp
       ResultQueueMgr* _result_queue_mgr = nullptr;
                       ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to