github-actions[bot] commented on code in PR #18115: URL: https://github.com/apache/doris/pull/18115#discussion_r1148595638
########## be/src/util/doris_bvar_metrics.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "doris_bvar_metrics.h" Review Comment: warning: #pragma once in main file [clang-diagnostic-pragma-once-outside-header] ```cpp #pragma once ^ ``` ########## be/src/util/doris_bvar_metrics.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "doris_bvar_metrics.h" + +namespace doris { + + void DorisBvarMetrics::initialize() { + + } + + void DorisBvarMetrics::put(BvarMetricEntity entity) { + { + std::lock_guard<bthread::Mutex>l(mutex_); + std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); + if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ + vec_.push_back(entity_ptr); + } Review Comment: warning: use of undeclared identifier 'entity_ptr' [clang-diagnostic-error] ```cpp if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ ^ ``` ########## be/src/util/doris_bvar_metrics.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "doris_bvar_metrics.h" + +namespace doris { + + void DorisBvarMetrics::initialize() { + + } + + void DorisBvarMetrics::put(BvarMetricEntity entity) { + { + std::lock_guard<bthread::Mutex>l(mutex_); + std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); + if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ + vec_.push_back(entity_ptr); + } + } Review Comment: warning: use of undeclared identifier 'vec_' [clang-diagnostic-error] ```cpp vec_.push_back(entity_ptr); ^ ``` ########## be/src/util/doris_bvar_metrics.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "doris_bvar_metrics.h" + +namespace doris { + + void DorisBvarMetrics::initialize() { + + } + + void DorisBvarMetrics::put(BvarMetricEntity entity) { + { + std::lock_guard<bthread::Mutex>l(mutex_); + std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); + if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ + vec_.push_back(entity_ptr); + } Review Comment: warning: use of undeclared identifier 'vec_' [clang-diagnostic-error] ```cpp if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ ^ ``` ########## be/src/util/doris_bvar_metrics.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "doris_bvar_metrics.h" + +namespace doris { + + void DorisBvarMetrics::initialize() { + + } + + void DorisBvarMetrics::put(BvarMetricEntity entity) { + { + std::lock_guard<bthread::Mutex>l(mutex_); + std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); + if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ + vec_.push_back(entity_ptr); Review Comment: warning: use of undeclared identifier 'entity_ptr' [clang-diagnostic-error] ```cpp std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); ^ ``` ########## be/src/util/doris_bvar_metrics.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "doris_bvar_metrics.h" + +namespace doris { + + void DorisBvarMetrics::initialize() { + + } + + void DorisBvarMetrics::put(BvarMetricEntity entity) { + { + std::lock_guard<bthread::Mutex>l(mutex_); + std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); + if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ + vec_.push_back(entity_ptr); Review Comment: warning: no member named 'shared_ptr' in namespace 'std' [clang-diagnostic-error] ```cpp std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); ^ ``` ########## be/src/util/doris_bvar_metrics.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "doris_bvar_metrics.h" + +namespace doris { + + void DorisBvarMetrics::initialize() { + + } + + void DorisBvarMetrics::put(BvarMetricEntity entity) { + { + std::lock_guard<bthread::Mutex>l(mutex_); + std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); + if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ + vec_.push_back(entity_ptr); + } Review Comment: warning: use of undeclared identifier 'vec_' [clang-diagnostic-error] ```cpp if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ ^ ``` ########## be/src/util/doris_bvar_metrics.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "doris_bvar_metrics.h" + +namespace doris { + + void DorisBvarMetrics::initialize() { + + } + + void DorisBvarMetrics::put(BvarMetricEntity entity) { + { + std::lock_guard<bthread::Mutex>l(mutex_); + std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); + if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ + vec_.push_back(entity_ptr); + } Review Comment: warning: use of undeclared identifier 'vec_' [clang-diagnostic-error] ```cpp if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ ^ ``` ########## be/src/util/doris_bvar_metrics.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "doris_bvar_metrics.h" + +namespace doris { + + void DorisBvarMetrics::initialize() { + + } + + void DorisBvarMetrics::put(BvarMetricEntity entity) { + { + std::lock_guard<bthread::Mutex>l(mutex_); + std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); + if(std::find(vec_.begin(),vec_.end(),entity_ptr)==vec_.end()){ + vec_.push_back(entity_ptr); Review Comment: warning: 'BvarMetricEntity' does not refer to a value [clang-diagnostic-error] ```cpp std::shared_ptr<BvarMetricEntity> entity_ptr(new BvarMetricEntity(entity)); ^ ``` **be/src/util/bvar_metrics.h:82:** declared here ```cpp class BvarMetricEntity{ ^ ``` ########## be/src/util/doris_bvar_metrics.h: ########## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "util/bvar_metrics.h" + +namespace doris { + + class DorisBvarMetrics{ + public: + static DorisBvarMetrics* instance(){ + static DorisBvarMetrics metrics; + return &metrics; + } + void initialize(); + void put(BvarMetricEntity entity); + std::string to_prometheus(); + private: + DorisBvarMetrics()=default; + std::string name_; + std::vector<std::shared_ptr<BvarMetricEntity>> vec_; Review Comment: warning: 'BvarMetricEntity' does not refer to a value [clang-diagnostic-error] ```cpp std::vector<std::shared_ptr<BvarMetricEntity>> vec_; ^ ``` **be/src/util/bvar_metrics.h:82:** declared here ```cpp class BvarMetricEntity{ ^ ``` ########## be/src/util/doris_bvar_metrics.h: ########## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "util/bvar_metrics.h" + +namespace doris { + + class DorisBvarMetrics{ + public: + static DorisBvarMetrics* instance(){ + static DorisBvarMetrics metrics; + return &metrics; + } + void initialize(); + void put(BvarMetricEntity entity); + std::string to_prometheus(); + private: + DorisBvarMetrics()=default; + std::string name_; + std::vector<std::shared_ptr<BvarMetricEntity>> vec_; Review Comment: warning: no member named 'shared_ptr' in namespace 'std' [clang-diagnostic-error] ```cpp std::vector<std::shared_ptr<BvarMetricEntity>> vec_; ^ ``` ########## be/src/util/doris_bvar_metrics.h: ########## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "util/bvar_metrics.h" + +namespace doris { + + class DorisBvarMetrics{ + public: + static DorisBvarMetrics* instance(){ + static DorisBvarMetrics metrics; + return &metrics; + } + void initialize(); + void put(BvarMetricEntity entity); + std::string to_prometheus(); + private: + DorisBvarMetrics()=default; + std::string name_; + std::vector<std::shared_ptr<BvarMetricEntity>> vec_; Review Comment: warning: expected member name or ';' after declaration specifiers [clang-diagnostic-error] ```cpp std::vector<std::shared_ptr<BvarMetricEntity>> vec_; ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
