github-actions[bot] commented on code in PR #18108:
URL: https://github.com/apache/doris/pull/18108#discussion_r1148320112
##########
be/src/vec/exec/format/file_reader/new_plain_binary_line_reader.h:
##########
@@ -33,8 +33,10 @@ class NewPlainBinaryLineReader : public LineReader {
~NewPlainBinaryLineReader() override;
- Status read_line(const uint8_t** ptr, size_t* size, bool* eof,
- const io::IOContext* io_ctx) override;
+ Status read_line(const uint8_t** ptr, size_t* size, bool* eof, const
io::IOContext* io_ctx,
+ size_t* read_bytes = nullptr) override;
+
+ bool is_support_read_bytes() { return true; }
Review Comment:
warning: 'is_support_read_bytes' overrides a member function but is not
marked 'override' [clang-diagnostic-inconsistent-missing-override]
```cpp
bool is_support_read_bytes() { return true; }
^
```
**be/src/exec/line_reader.h:31:** overridden virtual function is here
```cpp
virtual bool is_support_read_bytes() = 0; // true if the derived class
support read bytes fields
^
```
##########
be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h:
##########
@@ -38,8 +38,10 @@ class NewPlainTextLineReader : public LineReader {
~NewPlainTextLineReader() override;
- Status read_line(const uint8_t** ptr, size_t* size, bool* eof,
- const io::IOContext* io_ctx) override;
+ Status read_line(const uint8_t** ptr, size_t* size, bool* eof, const
io::IOContext* io_ctx,
+ size_t* read_bytes = nullptr) override;
+
+ bool is_support_read_bytes() { return true; }
Review Comment:
warning: 'is_support_read_bytes' overrides a member function but is not
marked 'override' [clang-diagnostic-inconsistent-missing-override]
```cpp
bool is_support_read_bytes() { return true; }
^
```
**be/src/exec/line_reader.h:31:** overridden virtual function is here
```cpp
virtual bool is_support_read_bytes() = 0; // true if the derived class
support read bytes fields
^
```
##########
be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h:
##########
@@ -38,8 +38,10 @@
~NewPlainTextLineReader() override;
- Status read_line(const uint8_t** ptr, size_t* size, bool* eof,
- const io::IOContext* io_ctx) override;
+ Status read_line(const uint8_t** ptr, size_t* size, bool* eof, const
io::IOContext* io_ctx,
+ size_t* read_bytes = nullptr) override;
+
+ bool is_support_read_bytes() { return true; }
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
bool is_support_read_bytes() override { return true; }
```
##########
be/src/vec/exec/format/file_reader/new_plain_binary_line_reader.h:
##########
@@ -33,8 +33,10 @@
~NewPlainBinaryLineReader() override;
- Status read_line(const uint8_t** ptr, size_t* size, bool* eof,
- const io::IOContext* io_ctx) override;
+ Status read_line(const uint8_t** ptr, size_t* size, bool* eof, const
io::IOContext* io_ctx,
+ size_t* read_bytes = nullptr) override;
+
+ bool is_support_read_bytes() { return true; }
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
bool is_support_read_bytes() override { return true; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
