github-actions[bot] commented on code in PR #18074:
URL: https://github.com/apache/doris/pull/18074#discussion_r1146461253
##########
be/src/vec/exec/format/parquet/parquet_thrift_util.h:
##########
@@ -35,8 +35,7 @@ namespace doris::vectorized {
constexpr uint8_t PARQUET_VERSION_NUMBER[4] = {'P', 'A', 'R', '1'};
constexpr uint32_t PARQUET_FOOTER_SIZE = 8;
-static Status parse_thrift_footer(io::FileReaderSPtr file,
- std::shared_ptr<FileMetaData>&
file_metadata) {
+static Status parse_thrift_footer(io::FileReaderSPtr file, FileMetaData**
file_metadata) {
Review Comment:
warning: unused function 'parse_thrift_footer'
[clang-diagnostic-unused-function]
```cpp
static Status parse_thrift_footer(io::FileReaderSPtr file,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
