github-actions[bot] commented on code in PR #18058:
URL: https://github.com/apache/doris/pull/18058#discussion_r1145890331
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -283,11 +283,11 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
return _dict.find_code_by_bound(value, greater, eq);
}
- void generate_hash_values_for_runtime_filter() override {
- _dict.generate_hash_values_for_runtime_filter(_type);
+ void initialize_hash_values_for_runtime_filter() override {
+ _dict.initialize_hash_values_for_runtime_filter();
}
- uint32_t get_hash_value(uint32_t idx) const { return
_dict.get_hash_value(_codes[idx]); }
+ uint32_t get_hash_value(uint32_t idx) { return
_dict.get_hash_value(_codes[idx], _type); }
Review Comment:
warning: 'this' argument to member function 'get_hash_value' has type 'const
doris::vectorized::ColumnDictionary<int>::Dictionary', but function is not
marked const [clang-diagnostic-error]
```cpp
uint32_t get_hash_value(uint32_t idx) const { return
_dict.get_hash_value(_codes[idx], _type); }
^
```
**be/src/vec/columns/column_dictionary.h:533:** in instantiation of member
function 'doris::vectorized::ColumnDictionary<int>::get_hash_value' requested
here
```cpp
template class ColumnDictionary<int32_t>;
^
```
**be/src/vec/columns/column_dictionary.h:373:** 'get_hash_value' declared
here
```cpp
inline uint32_t get_hash_value(T code, FieldType type) {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
