kaka11chen commented on code in PR #17594:
URL: https://github.com/apache/doris/pull/17594#discussion_r1136969670
##########
be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:
##########
@@ -384,6 +384,40 @@ Status ScalarColumnReader::_read_nested_column(ColumnPtr&
doris_column, DataType
}
return Status::OK();
}
+Status ScalarColumnReader::read_dict_values_to_column(MutableColumnPtr&
doris_column,
+ bool* has_dict) {
+ bool loaded;
+ RETURN_IF_ERROR(_try_load_dict_page(&loaded, has_dict));
+ if (loaded && has_dict) {
+ return _chunk_reader->read_dict_values_to_column(doris_column);
+ }
+ return Status::OK();
+}
+
+Status ScalarColumnReader::get_dict_codes(const ColumnString* columnString,
+ std::vector<int32_t>* dict_codes) {
+ return _chunk_reader->get_dict_codes(columnString, dict_codes);
Review Comment:
ok
##########
be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.h:
##########
@@ -142,8 +143,23 @@ class ColumnChunkReader {
return _statistics;
}
+ Status read_dict_values_to_column(MutableColumnPtr& doris_column) {
+ return _decoders[static_cast<int>(tparquet::Encoding::RLE_DICTIONARY)]
+ ->read_dict_values_to_column(doris_column);
+ }
+
+ Status get_dict_codes(const ColumnString* columnString,
std::vector<int32_t>* dict_codes) {
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
