liutang123 commented on code in PR #17615:
URL: https://github.com/apache/doris/pull/17615#discussion_r1136639765


##########
be/src/runtime/query_fragments_ctx.h:
##########
@@ -122,6 +123,10 @@ class QueryFragmentsCtx {
 
     vectorized::RuntimePredicate& get_runtime_predicate() { return 
_runtime_predicate; }
 
+    void set_task_group(taskgroup::TaskGroupPtr& rs_group) { _task_group = 
rs_group; }
+
+    taskgroup::TaskGroup* get_task_group() { return _task_group.get(); }

Review Comment:
   task group is a shared ptr of `QueryFragmentCtx`. When using 
`QueryFragmentsCtx `, task group can not be desctructed. If we exec 
`get_task_group` in a destructed `QueryFragmentsCtx`, there maybe something 
wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to