github-actions[bot] commented on code in PR #17715:
URL: https://github.com/apache/doris/pull/17715#discussion_r1133418782


##########
be/src/udf/udf.h:
##########
@@ -132,16 +145,39 @@ class FunctionContext {
     ~FunctionContext() = default;
 
 private:
-    friend class doris::FunctionContextImpl;
-
-    FunctionContext();
+    FunctionContext() = default;
 
     // Disable copy ctor and assignment operator
     FunctionContext(const FunctionContext& other);
 
     FunctionContext& operator=(const FunctionContext& other);
 
-    std::unique_ptr<doris::FunctionContextImpl> _impl; // Owned by this object.
+private:

Review Comment:
   warning: redundant access specifier has the same accessibility as the 
previous access specifier [readability-redundant-access-specifiers]
   
   ```suggestion
   
   ```
   **be/src/udf/udf.h:146:** previously declared here
   ```cpp
   private:
   ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to