morningman commented on code in PR #17694:
URL: https://github.com/apache/doris/pull/17694#discussion_r1133365282


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalCatalog.java:
##########
@@ -240,6 +240,20 @@ public List<String> getDbNames() {
         return listDatabaseNames(null);
     }
 
+    @Override
+    public List<String> getDbNamesOrEmpty() {
+        if (initialized) {

Review Comment:
   it is strange because in `getDbNames()`, it will try to initialize it and 
then get databases.
   if we add `if (initialized)` here, it will not do initialization anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to