englefly commented on code in PR #17661: URL: https://github.com/apache/doris/pull/17661#discussion_r1133173444
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/FunctionBinder.java: ########## @@ -212,4 +215,17 @@ public Expression visitBetween(Between between, CascadesContext context) { Between newBetween = between.withChildren(rewrittenChildren); return TypeCoercionUtils.processBetween(newBetween); } + + @Override + public Expression visitInSubquery(InSubquery inSubquery, CascadesContext context) { + Expression newCompareExpr = inSubquery.getCompareExpr().accept(this, context); + Expression newListQuery = inSubquery.getListQuery().accept(this, context); + ComparisonPredicate newCpAfterUnNestingSubquery = + new EqualTo(newCompareExpr, ((ListQuery) newListQuery).getQueryPlan().getOutput().get(0)); Review Comment: there are some exceptions. for example: select * from T where T.a in (select b from B) T.a is int column, and B.b is bitmap column. the semantics of this sql is bitmap_contains( bitmap_union(B.b), T.a) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org