github-actions[bot] commented on code in PR #17629:
URL: https://github.com/apache/doris/pull/17629#discussion_r1132305868
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -125,31 +120,31 @@ class StringTypeInvertedIndexReader : public
InvertedIndexReader {
Status new_iterator(const TabletIndex* index_meta, OlapReaderStatistics*
stats,
InvertedIndexIterator** iterator) override;
+ template <PrimitiveType field_type>
+ std::unique_ptr<lucene::search::Query>
generate_query(InvertedIndexQuery<field_type>& query,
Review Comment:
warning: no template named 'InvertedIndexQuery' [clang-diagnostic-error]
```cpp
std::unique_ptr<lucene::search::Query>
generate_query(InvertedIndexQuery<field_type>& query,
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -125,31 +120,31 @@
Status new_iterator(const TabletIndex* index_meta, OlapReaderStatistics*
stats,
InvertedIndexIterator** iterator) override;
+ template <PrimitiveType field_type>
+ std::unique_ptr<lucene::search::Query>
generate_query(InvertedIndexQuery<field_type>& query,
+ const std::string&
column_name);
Status query(OlapReaderStatistics* stats, const std::string& column_name,
- const void* query_value, InvertedIndexQueryType query_type,
- InvertedIndexParserType analyser_type, roaring::Roaring*
bit_map) override;
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
Review Comment:
warning: unknown type name 'InvertedIndexQueryType' [clang-diagnostic-error]
```cpp
InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -125,31 +120,31 @@
Status new_iterator(const TabletIndex* index_meta, OlapReaderStatistics*
stats,
InvertedIndexIterator** iterator) override;
+ template <PrimitiveType field_type>
+ std::unique_ptr<lucene::search::Query>
generate_query(InvertedIndexQuery<field_type>& query,
+ const std::string&
column_name);
Status query(OlapReaderStatistics* stats, const std::string& column_name,
- const void* query_value, InvertedIndexQueryType query_type,
- InvertedIndexParserType analyser_type, roaring::Roaring*
bit_map) override;
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
+ roaring::Roaring* bit_map) override;
Status try_query(OlapReaderStatistics* stats, const std::string&
column_name,
- const void* query_value, InvertedIndexQueryType
query_type,
- InvertedIndexParserType analyser_type, uint32_t* count)
override {
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
Review Comment:
warning: unknown type name 'InvertedIndexQueryType' [clang-diagnostic-error]
```cpp
InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -125,31 +120,31 @@
Status new_iterator(const TabletIndex* index_meta, OlapReaderStatistics*
stats,
InvertedIndexIterator** iterator) override;
+ template <PrimitiveType field_type>
+ std::unique_ptr<lucene::search::Query>
generate_query(InvertedIndexQuery<field_type>& query,
+ const std::string&
column_name);
Status query(OlapReaderStatistics* stats, const std::string& column_name,
- const void* query_value, InvertedIndexQueryType query_type,
- InvertedIndexParserType analyser_type, roaring::Roaring*
bit_map) override;
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
+ roaring::Roaring* bit_map) override;
Status try_query(OlapReaderStatistics* stats, const std::string&
column_name,
- const void* query_value, InvertedIndexQueryType
query_type,
- InvertedIndexParserType analyser_type, uint32_t* count)
override {
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
+ uint32_t* count) override {
return Status::Error<ErrorCode::NOT_IMPLEMENTED_ERROR>();
}
InvertedIndexReaderType type() override;
};
+template <PrimitiveType field_type>
class InvertedIndexVisitor : public
lucene::util::bkd::bkd_reader::intersect_visitor {
private:
roaring::Roaring* hits;
uint32_t num_hits;
bool only_count;
lucene::util::bkd::bkd_reader* reader;
- InvertedIndexQueryType query_type;
-
-public:
- std::string queryMin;
- std::string queryMax;
+ InvertedIndexQuery<field_type>* query;
Review Comment:
warning: no template named 'InvertedIndexQuery' [clang-diagnostic-error]
```cpp
InvertedIndexQuery<field_type>* query;
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -168,6 +163,18 @@
lucene::util::bkd::relation compare(std::vector<uint8_t>& minPacked,
std::vector<uint8_t>& maxPacked)
override;
uint32_t get_num_hits() const { return num_hits; }
+
+ bool intersect_point(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ bool point_is_in_list(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
Review Comment:
warning: no template named 'InvertedIndexQuery' [clang-diagnostic-error]
```cpp
bool point_is_in_list(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -168,6 +163,18 @@
lucene::util::bkd::relation compare(std::vector<uint8_t>& minPacked,
std::vector<uint8_t>& maxPacked)
override;
uint32_t get_num_hits() const { return num_hits; }
+
+ bool intersect_point(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
Review Comment:
warning: no template named 'InvertedIndexQuery' [clang-diagnostic-error]
```cpp
bool intersect_point(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -125,31 +120,31 @@
Status new_iterator(const TabletIndex* index_meta, OlapReaderStatistics*
stats,
InvertedIndexIterator** iterator) override;
+ template <PrimitiveType field_type>
+ std::unique_ptr<lucene::search::Query>
generate_query(InvertedIndexQuery<field_type>& query,
+ const std::string&
column_name);
Status query(OlapReaderStatistics* stats, const std::string& column_name,
- const void* query_value, InvertedIndexQueryType query_type,
- InvertedIndexParserType analyser_type, roaring::Roaring*
bit_map) override;
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
+ roaring::Roaring* bit_map) override;
Status try_query(OlapReaderStatistics* stats, const std::string&
column_name,
- const void* query_value, InvertedIndexQueryType
query_type,
- InvertedIndexParserType analyser_type, uint32_t* count)
override {
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
+ uint32_t* count) override {
return Status::Error<ErrorCode::NOT_IMPLEMENTED_ERROR>();
}
InvertedIndexReaderType type() override;
};
+template <PrimitiveType field_type>
class InvertedIndexVisitor : public
lucene::util::bkd::bkd_reader::intersect_visitor {
private:
roaring::Roaring* hits;
uint32_t num_hits;
bool only_count;
lucene::util::bkd::bkd_reader* reader;
- InvertedIndexQueryType query_type;
-
-public:
- std::string queryMin;
- std::string queryMax;
+ InvertedIndexQuery<field_type>* query;
public:
- InvertedIndexVisitor(roaring::Roaring* hits, InvertedIndexQueryType
query_type,
+ InvertedIndexVisitor(roaring::Roaring* hits,
InvertedIndexQuery<field_type>* q,
Review Comment:
warning: no template named 'InvertedIndexQuery' [clang-diagnostic-error]
```cpp
InvertedIndexVisitor(roaring::Roaring* hits,
InvertedIndexQuery<field_type>* q,
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -168,6 +163,18 @@
lucene::util::bkd::relation compare(std::vector<uint8_t>& minPacked,
std::vector<uint8_t>& maxPacked)
override;
uint32_t get_num_hits() const { return num_hits; }
+
+ bool intersect_point(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ bool point_is_in_list(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ bool point_is_in_range(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ lucene::util::bkd::relation intersect_range(uint8_t* minValue, uint8_t*
maxValue, int offset,
+
InvertedIndexQuery<field_type>* q);
Review Comment:
warning: no template named 'InvertedIndexQuery' [clang-diagnostic-error]
```cpp
InvertedIndexQuery<field_type>* q);
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -168,6 +163,18 @@
lucene::util::bkd::relation compare(std::vector<uint8_t>& minPacked,
std::vector<uint8_t>& maxPacked)
override;
uint32_t get_num_hits() const { return num_hits; }
+
+ bool intersect_point(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ bool point_is_in_list(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ bool point_is_in_range(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
Review Comment:
warning: no template named 'InvertedIndexQuery' [clang-diagnostic-error]
```cpp
bool point_is_in_range(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -168,6 +163,18 @@
lucene::util::bkd::relation compare(std::vector<uint8_t>& minPacked,
std::vector<uint8_t>& maxPacked)
override;
uint32_t get_num_hits() const { return num_hits; }
+
+ bool intersect_point(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ bool point_is_in_list(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ bool point_is_in_range(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ lucene::util::bkd::relation intersect_range(uint8_t* minValue, uint8_t*
maxValue, int offset,
+
InvertedIndexQuery<field_type>* q);
+ lucene::util::bkd::relation relation_between_point_and_range(uint8_t*
minValue,
+ uint8_t*
maxValue, int offset,
+
InvertedIndexQuery<field_type>* q);
Review Comment:
warning: no template named 'InvertedIndexQuery' [clang-diagnostic-error]
```cpp
InvertedIndexQuery<field_type>* q);
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -185,15 +192,15 @@
InvertedIndexIterator** iterator) override;
Status query(OlapReaderStatistics* stats, const std::string& column_name,
- const void* query_value, InvertedIndexQueryType query_type,
- InvertedIndexParserType analyser_type, roaring::Roaring*
bit_map) override;
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
+ roaring::Roaring* bit_map) override;
Status try_query(OlapReaderStatistics* stats, const std::string&
column_name,
- const void* query_value, InvertedIndexQueryType
query_type,
- InvertedIndexParserType analyser_type, uint32_t* count)
override;
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
Review Comment:
warning: unknown type name 'InvertedIndexQueryType' [clang-diagnostic-error]
```cpp
InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -185,15 +192,15 @@
InvertedIndexIterator** iterator) override;
Status query(OlapReaderStatistics* stats, const std::string& column_name,
- const void* query_value, InvertedIndexQueryType query_type,
- InvertedIndexParserType analyser_type, roaring::Roaring*
bit_map) override;
+ InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
Review Comment:
warning: unknown type name 'InvertedIndexQueryType' [clang-diagnostic-error]
```cpp
InvertedIndexQueryType* query, InvertedIndexParserType
analyser_type,
^
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -168,6 +163,18 @@
lucene::util::bkd::relation compare(std::vector<uint8_t>& minPacked,
std::vector<uint8_t>& maxPacked)
override;
uint32_t get_num_hits() const { return num_hits; }
+
+ bool intersect_point(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ bool point_is_in_list(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ bool point_is_in_range(uint8_t* packedValue, int offset,
InvertedIndexQuery<field_type>* q);
+ lucene::util::bkd::relation intersect_range(uint8_t* minValue, uint8_t*
maxValue, int offset,
+
InvertedIndexQuery<field_type>* q);
+ lucene::util::bkd::relation relation_between_point_and_range(uint8_t*
minValue,
+ uint8_t*
maxValue, int offset,
+
InvertedIndexQuery<field_type>* q);
+ lucene::util::bkd::relation relation_between_range_and_range(uint8_t*
minValue,
+ uint8_t*
maxValue, int offset,
+
InvertedIndexQuery<field_type>* q);
Review Comment:
warning: no template named 'InvertedIndexQuery' [clang-diagnostic-error]
```cpp
InvertedIndexQuery<field_type>* q);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
