eldenmoon commented on code in PR #17494: URL: https://github.com/apache/doris/pull/17494#discussion_r1131904513
########## be/src/vec/common/schema_util.h: ########## @@ -43,35 +45,23 @@ DataTypePtr get_base_type_of_array(const DataTypePtr& type); /// Returns Array with requested number of dimensions and no scalars. Array create_empty_array_field(size_t num_dimensions); -// NOTICE: the last column must be dynamic column -// 1. The dynamic column will be parsed to ColumnObject and the parsed column will -// be flattened to multiple subcolumns, thus the dynamic schema is infered from the -// dynamic column. -// 2. Schema change which is add columns will be performed if the infered schema is -// different from the original tablet schema, new columns added to schema change history -Status parse_and_expand_dynamic_column(Block& block, const TabletSchema& schema_hints, - LocalSchemaChangeRecorder* history); - -Status parse_object_column(Block& block, size_t position); - -Status parse_object_column(ColumnObject& dest, const IColumn& src, bool need_finalize, - const int* row_begin, const int* row_end); +// Cast column to dst type +Status cast_column(const ColumnWithTypeAndName& arg, const DataTypePtr& type, ColumnPtr* result); -// Object column will be flattened and if replace_if_duplicated +// Object column will be unfolded and if replace_if_duplicated Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
