[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17494: [Feature](Dynamic schema table) step1 support schema change expression

[via GitHub]

github-actions[bot] commented on code in PR #17494:
URL: https://github.com/apache/doris/pull/17494#discussion_r1130795896


##########
be/src/vec/exec/scan/vfile_scanner.cpp:
##########
@@ -798,12 +721,6 @@ Status VFileScanner::_init_expr_ctxes() {
     // If last slot is_variant from stream plan which indicate table is 
dynamic schema
     _is_dynamic_schema =
             _output_tuple_desc && 
_output_tuple_desc->slots().back()->type().is_variant_type();
-    if (_is_dynamic_schema) {
-        _full_base_schema_view.reset(new 
vectorized::schema_util::FullBaseSchemaView);
-        _full_base_schema_view->db_name = 
_output_tuple_desc->table_desc()->database();
-        _full_base_schema_view->table_name = 
_output_tuple_desc->table_desc()->name();
-        _full_base_schema_view->table_id = 
_output_tuple_desc->table_desc()->table_id();
-    }
     return Status::OK();
 }

Review Comment:
   warning: version control conflict marker in file [clang-diagnostic-error]
   ```cpp
   <<<<<<< HEAD
   ^
   ```
   



##########
be/src/vec/exec/scan/vfile_scanner.cpp:
##########
@@ -798,12 +721,6 @@
     // If last slot is_variant from stream plan which indicate table is 
dynamic schema
     _is_dynamic_schema =
             _output_tuple_desc && 
_output_tuple_desc->slots().back()->type().is_variant_type();
-    if (_is_dynamic_schema) {
-        _full_base_schema_view.reset(new 
vectorized::schema_util::FullBaseSchemaView);
-        _full_base_schema_view->db_name = 
_output_tuple_desc->table_desc()->database();
-        _full_base_schema_view->table_name = 
_output_tuple_desc->table_desc()->name();
-        _full_base_schema_view->table_id = 
_output_tuple_desc->table_desc()->table_id();
-    }
     return Status::OK();
 }
 

Review Comment:
   warning: use of undeclared identifier '_full_base_schema_view' 
[clang-diagnostic-error]
   ```cpp
           _full_base_schema_view.reset(new 
vectorized::schema_util::FullBaseSchemaView);
           ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org