github-actions[bot] commented on code in PR #17615: URL: https://github.com/apache/doris/pull/17615#discussion_r1130752353
########## be/src/runtime/task_group/task_group.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "task_group.h" +#include "pipeline/pipeline_task.h" + +namespace doris { +namespace taskgroup { + +pipeline::PipelineTask* TaskGroupEntity::take() { + if (_queue.empty()) { + return nullptr; + } + auto task = _queue.front(); + _queue.pop(); + return task; +} + +void TaskGroupEntity::incr_runtime_ns(int64_t runtime_ns) { + auto v_time = runtime_ns / _rs->cpu_share(); + _vruntime_ns += v_time; +} + +void adjust_vruntime_ns(int64_t vruntime_ns) { + _vruntime_ns = vruntime_ns; Review Comment: warning: explicitly assigning value of variable of type 'int64_t' (aka 'long') to itself [clang-diagnostic-self-assign] ```cpp _vruntime_ns = vruntime_ns; ^ ``` ########## be/src/runtime/task_group/task_group.cpp: ########## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "task_group.h" +#include "pipeline/pipeline_task.h" + +namespace doris { +namespace taskgroup { + +pipeline::PipelineTask* TaskGroupEntity::take() { + if (_queue.empty()) { + return nullptr; + } + auto task = _queue.front(); + _queue.pop(); + return task; +} + +void TaskGroupEntity::incr_runtime_ns(int64_t runtime_ns) { + auto v_time = runtime_ns / _rs->cpu_share(); + _vruntime_ns += v_time; +} + +void adjust_vruntime_ns(int64_t vruntime_ns) { + _vruntime_ns = vruntime_ns; Review Comment: warning: use of undeclared identifier '_vruntime_ns'; did you mean 'vruntime_ns'? [clang-diagnostic-error] ```suggestion vruntime_ns = vruntime_ns; ``` **be/src/runtime/task_group/task_group.cpp:37:** 'vruntime_ns' declared here ```cpp void adjust_vruntime_ns(int64_t vruntime_ns) { ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
