924060929 opened a new pull request, #17579:
URL: https://github.com/apache/doris/pull/17579

   # Proposed changes
   
   This pr refactor the column pruning by the visitor, the good sides
   1. easy to provide ability of column pruning for new plan by implement the 
interface `OutputPrunable`, don't need to add new rule like 
`PruneXxxChildColumns`
   2. support shrink output field in some plans, this can skip some useless 
operation so improvement
   example:
   ```sql
   select id 
   from (
     select id, sum(age)
     from student
   )a
   ```
   
   we should prune the useless `sum (age)` in the aggregate.
   before refactor:
   ```
   LogicalProject ( distinct=false, projects=[id#0], excepts=[], 
canEliminate=true )
   +--LogicalSubQueryAlias ( qualifier=[a] )
      +--LogicalAggregate ( groupByExpr=[], outputExpr=[id#0, sum(age#2) AS 
`sum(age)`#4], hasRepeat=false )
         +--LogicalProject ( distinct=false, projects=[id#0, age#2], 
excepts=[], canEliminate=true )
            +--LogicalOlapScan ( qualified=default_cluster:test.student, 
indexName=<index_not_selected>, selectedIndexId=10007, preAgg=ON )
   ```
   
   after refactor:
   ```
   LogicalProject ( distinct=false, projects=[id#0], excepts=[], 
canEliminate=true )
   +--LogicalSubQueryAlias ( qualifier=[a] )
      +--LogicalAggregate ( groupByExpr=[], outputExpr=[id#0], hasRepeat=false )
         +--LogicalProject ( distinct=false, projects=[id#0], excepts=[], 
canEliminate=true )
            +--LogicalOlapScan ( qualified=default_cluster:test.student, 
indexName=<index_not_selected>, selectedIndexId=10007, preAgg=ON )
   ```
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [x] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to