englefly commented on code in PR #17284:
URL: https://github.com/apache/doris/pull/17284#discussion_r1127290558
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/ExtractAndNormalizeWindowExpression.java:
##########
@@ -61,7 +65,8 @@ public Rule build() {
} else {
boolean needAggregate = bottomProjects.stream().anyMatch(expr
->
expr.anyMatch(AggregateFunction.class::isInstance));
- if (needAggregate) {
+ boolean hasAggChild = isProjectOnAggregate(project);
Review Comment:
"isProjectOnAggregate" can be removed.
If an agg-fun need to be push down and the child is AggNode, the agg-fun is
already pushed down in NormalizeAggregation Rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
