This is an automated email from the ASF dual-hosted git repository.
luzhijing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1d858db617 [feature](filecache) add a const parameter to control the
cache version (#17441)
1d858db617 is described below
commit 1d858db617d58d0e3580af4674fe434b3c6cccef
Author: Ashin Gau <ashin...@users.noreply.github.com>
AuthorDate: Tue Mar 7 08:03:18 2023 +0800
[feature](filecache) add a const parameter to control the cache version
(#17441)
* [feature](filecache) add a const parameter to control the cache version
* fix
---
be/src/io/cache/block/block_file_cache.cpp | 17 +++++---
be/src/io/cache/block/block_file_cache.h | 7 +++-
be/src/io/cache/block/block_lru_file_cache.cpp | 55 +++++++++++++++-----------
be/test/io/cache/file_block_cache_test.cpp | 10 ++++-
4 files changed, 56 insertions(+), 33 deletions(-)
diff --git a/be/src/io/cache/block/block_file_cache.cpp
b/be/src/io/cache/block/block_file_cache.cpp
index 292903c812..0b97facff5 100644
--- a/be/src/io/cache/block/block_file_cache.cpp
+++ b/be/src/io/cache/block/block_file_cache.cpp
@@ -32,9 +32,6 @@ namespace fs = std::filesystem;
namespace doris {
namespace io {
-const std::string IFileCache::FILE_CACHE_VERSION = "2.0";
-const int IFileCache::KEY_PREFIX_LENGTH = 3;
-
IFileCache::IFileCache(const std::string& cache_base_path, const
FileCacheSettings& cache_settings)
: _cache_base_path(cache_base_path),
_max_size(cache_settings.max_size),
@@ -58,13 +55,21 @@ std::string IFileCache::get_path_in_local_cache(const Key&
key, size_t offset,
bool is_persistent) const {
auto key_str = key.to_string();
std::string suffix = is_persistent ? "_persistent" : "";
- return fs::path(_cache_base_path) / key_str.substr(0, KEY_PREFIX_LENGTH) /
key_str /
- (std::to_string(offset) + suffix);
+ if constexpr (USE_CACHE_VERSION2) {
+ return fs::path(_cache_base_path) / key_str.substr(0,
KEY_PREFIX_LENGTH) / key_str /
+ (std::to_string(offset) + suffix);
+ } else {
+ return fs::path(_cache_base_path) / key_str / (std::to_string(offset)
+ suffix);
+ }
}
std::string IFileCache::get_path_in_local_cache(const Key& key) const {
auto key_str = key.to_string();
- return fs::path(_cache_base_path) / key_str.substr(0, KEY_PREFIX_LENGTH) /
key_str;
+ if constexpr (USE_CACHE_VERSION2) {
+ return fs::path(_cache_base_path) / key_str.substr(0,
KEY_PREFIX_LENGTH) / key_str;
+ } else {
+ return fs::path(_cache_base_path) / key_str;
+ }
}
std::string IFileCache::get_version_path() const {
diff --git a/be/src/io/cache/block/block_file_cache.h
b/be/src/io/cache/block/block_file_cache.h
index 3e3113eb3c..81050c49b4 100644
--- a/be/src/io/cache/block/block_file_cache.h
+++ b/be/src/io/cache/block/block_file_cache.h
@@ -43,8 +43,11 @@ class IFileCache {
friend struct FileBlocksHolder;
public:
- static const std::string FILE_CACHE_VERSION;
- static const int KEY_PREFIX_LENGTH;
+ /// use version 2 when USE_CACHE_VERSION2 = true, while use version 1 if
false
+ /// version 1.0: cache_base_path / key / offset
+ /// version 2.0: cache_base_path / key_prefix / key / offset
+ static constexpr bool USE_CACHE_VERSION2 = true;
+ static constexpr int KEY_PREFIX_LENGTH = 3;
struct Key {
uint128_t key;
diff --git a/be/src/io/cache/block/block_lru_file_cache.cpp
b/be/src/io/cache/block/block_lru_file_cache.cpp
index 446c662b88..e2b1063007 100644
--- a/be/src/io/cache/block/block_lru_file_cache.cpp
+++ b/be/src/io/cache/block/block_lru_file_cache.cpp
@@ -639,7 +639,7 @@ void LRUFileCache::remove(const Key& key, bool
is_persistent, size_t offset,
void LRUFileCache::load_cache_info_into_memory(std::lock_guard<std::mutex>&
cache_lock) {
/// version 1.0: cache_base_path / key / offset
/// version 2.0: cache_base_path / key_prefix / key / offset
- if (read_file_cache_version() != FILE_CACHE_VERSION) {
+ if (USE_CACHE_VERSION2 && read_file_cache_version() != "2.0") {
// move directories format as version 2.0
fs::directory_iterator key_it {_cache_base_path};
for (; key_it != fs::directory_iterator(); ++key_it) {
@@ -675,22 +675,7 @@ void
LRUFileCache::load_cache_info_into_memory(std::lock_guard<std::mutex>& cach
uint64_t offset = 0;
size_t size = 0;
std::vector<std::pair<LRUQueue::Iterator, bool>> queue_entries;
-
- /// version 2.0: cache_base_path / key_prefix / key / offset
- fs::directory_iterator key_prefix_it {_cache_base_path};
- for (; key_prefix_it != fs::directory_iterator(); ++key_prefix_it) {
- if (!key_prefix_it->is_directory()) {
- // maybe version hits file
- continue;
- }
- if (key_prefix_it->path().filename().native().size() !=
KEY_PREFIX_LENGTH) {
- LOG(WARNING) << "Unknown directory " <<
key_prefix_it->path().native()
- << ", try to remove it";
- std::filesystem::remove(key_prefix_it->path());
- continue;
- }
-
- fs::directory_iterator key_it {key_prefix_it->path()};
+ auto scan_file_cache = [&](fs::directory_iterator& key_it) {
for (; key_it != fs::directory_iterator(); ++key_it) {
key = Key(
vectorized::unhex_uint<uint128_t>(key_it->path().filename().native().c_str()));
@@ -747,6 +732,27 @@ void
LRUFileCache::load_cache_info_into_memory(std::lock_guard<std::mutex>& cach
}
}
}
+ };
+
+ if constexpr (USE_CACHE_VERSION2) {
+ fs::directory_iterator key_prefix_it {_cache_base_path};
+ for (; key_prefix_it != fs::directory_iterator(); ++key_prefix_it) {
+ if (!key_prefix_it->is_directory()) {
+ // maybe version hits file
+ continue;
+ }
+ if (key_prefix_it->path().filename().native().size() !=
KEY_PREFIX_LENGTH) {
+ LOG(WARNING) << "Unknown directory " <<
key_prefix_it->path().native()
+ << ", try to remove it";
+ std::filesystem::remove(key_prefix_it->path());
+ continue;
+ }
+ fs::directory_iterator key_it {key_prefix_it->path()};
+ scan_file_cache(key_it);
+ }
+ } else {
+ fs::directory_iterator key_it {_cache_base_path};
+ scan_file_cache(key_it);
}
/// Shuffle cells to have random order in LRUQueue as at startup all cells
have the same priority.
@@ -760,12 +766,15 @@ void
LRUFileCache::load_cache_info_into_memory(std::lock_guard<std::mutex>& cach
}
Status LRUFileCache::write_file_cache_version() const {
- std::string version_path = get_version_path();
- Slice version(FILE_CACHE_VERSION);
- FileWriterPtr version_writer;
- RETURN_IF_ERROR(global_local_filesystem()->create_file(version_path,
&version_writer));
- RETURN_IF_ERROR(version_writer->append(version));
- return version_writer->close();
+ if constexpr (USE_CACHE_VERSION2) {
+ std::string version_path = get_version_path();
+ Slice version("2.0");
+ FileWriterPtr version_writer;
+ RETURN_IF_ERROR(global_local_filesystem()->create_file(version_path,
&version_writer));
+ RETURN_IF_ERROR(version_writer->append(version));
+ return version_writer->close();
+ }
+ return Status::OK();
}
std::string LRUFileCache::read_file_cache_version() const {
diff --git a/be/test/io/cache/file_block_cache_test.cpp
b/be/test/io/cache/file_block_cache_test.cpp
index 157e20b2f7..5f45139305 100644
--- a/be/test/io/cache/file_block_cache_test.cpp
+++ b/be/test/io/cache/file_block_cache_test.cpp
@@ -54,7 +54,11 @@ std::vector<io::FileBlockSPtr> fromHolder(const
io::FileBlocksHolder& holder) {
std::string getFileBlockPath(const std::string& base_path, const
io::IFileCache::Key& key,
size_t offset) {
auto key_str = key.to_string();
- return fs::path(base_path) / key_str.substr(0, 3) / key_str /
std::to_string(offset);
+ if constexpr (IFileCache::USE_CACHE_VERSION2) {
+ return fs::path(base_path) / key_str.substr(0, 3) / key_str /
std::to_string(offset);
+ } else {
+ return fs::path(base_path) / key_str / std::to_string(offset);
+ }
}
void download(io::FileBlockSPtr file_segment) {
@@ -62,7 +66,9 @@ void download(io::FileBlockSPtr file_segment) {
size_t size = file_segment->range().size();
auto key_str = key.to_string();
- auto subdir = fs::path(cache_base_path) / key_str.substr(0, 3) / key_str;
+ auto subdir = IFileCache::USE_CACHE_VERSION2
+ ? fs::path(cache_base_path) / key_str.substr(0, 3) /
key_str
+ : fs::path(cache_base_path) / key_str;
ASSERT_TRUE(fs::exists(subdir));
std::string data(size, '0');
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
