This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 3e2d2731d5 [fix](log) fix and clarify error msg for tablet writer
write failure (#14078) (#17472)
3e2d2731d5 is described below
commit 3e2d2731d57194ac95859a722ee757ba24f8548c
Author: zhengyu <freeman.zhang1...@gmail.com>
AuthorDate: Mon Mar 6 21:13:04 2023 +0800
[fix](log) fix and clarify error msg for tablet writer write failure
(#14078) (#17472)
fmt::format dosen't support non-template object as args, even if it
implements
`to_string()` or `operator<<`. so orignal code may cause false to be printed
instead of real cause of the failure. So to_string() need to be manually
invoked.
Signed-off-by: freemandealer <freeman.zhang1...@gmail.com>
---
be/src/runtime/tablets_channel.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/src/runtime/tablets_channel.cpp
b/be/src/runtime/tablets_channel.cpp
index 6eb8762edd..70a0304056 100644
--- a/be/src/runtime/tablets_channel.cpp
+++ b/be/src/runtime/tablets_channel.cpp
@@ -489,7 +489,7 @@ Status TabletsChannel::add_batch(const
TabletWriterAddRequest& request,
if (!st.ok()) {
auto err_msg =
fmt::format("tablet writer write failed, tablet_id={},
txn_id={}, err={}",
- tablet_to_rowidxs_it.first, _txn_id, st);
+ tablet_to_rowidxs_it.first, _txn_id,
st.to_string());
LOG(WARNING) << err_msg;
PTabletError* error = tablet_errors->Add();
error->set_tablet_id(tablet_to_rowidxs_it.first);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
