yiguolei commented on code in PR #15917:
URL: https://github.com/apache/doris/pull/15917#discussion_r1125980962
##########
be/src/vec/core/block.cpp:
##########
@@ -321,13 +322,16 @@ void Block::check_number_of_rows(bool allow_null_columns)
const {
if (rows == -1) {
rows = size;
} else if (rows != size) {
- LOG(FATAL) << fmt::format("Sizes of columns doesn't match:
{}:{},{}:{}",
- data.front().name, rows, elem.name,
size);
+ LOG(FATAL) << fmt::format("Sizes of columns doesn't match:
{}:{},{}:{}, col size: {}",
+ data.front().name, rows, elem.name,
size, each_col_size());
}
}
}
size_t Block::rows() const {
+ if (_effective_col != INT_MIN) {
Review Comment:
use column const during filter block. and then replace column after filter
block.
Then do not need add this effective col any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
