amorynan commented on code in PR #17330:
URL: https://github.com/apache/doris/pull/17330#discussion_r1125825585
##########
be/src/vec/columns/column_map.cpp:
##########
@@ -83,34 +141,45 @@ void ColumnMap::insert_data(const char*, size_t) {
void ColumnMap::insert(const Field& x) {
const auto& map = doris::vectorized::get<const Map&>(x);
CHECK_EQ(map.size(), 2);
- keys->insert(map[0]);
- values->insert(map[1]);
+ const auto& k_f = doris::vectorized::get<const Array&>(map[0]);
+ const auto& v_f = doris::vectorized::get<const Array&>(map[1]);
+
+ size_t element_size = k_f.size();
+
+ for (size_t i = 0; i < element_size; ++i) {
+ keys_column->insert(k_f[i]);
Review Comment:
is that insert_many means appends one element multiple times ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
