github-actions[bot] commented on code in PR #17431:
URL: https://github.com/apache/doris/pull/17431#discussion_r1125638322
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -146,33 +151,32 @@ void OrcReader::_init_profile() {
}
}
-Status OrcReader::init_reader(
- std::unordered_map<std::string, ColumnValueRangeType>*
colname_to_value_range) {
- SCOPED_RAW_TIMER(&_statistics.parse_meta_time);
- if (_file_reader == nullptr) {
+Status OrcReader::_create_file_reader() {
+ if (_file_input_stream.get() == nullptr) {
Review Comment:
warning: redundant get() call on smart pointer
[readability-redundant-smartptr-get]
```suggestion
if (_file_input_stream == nullptr) {
```
##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -261,6 +238,9 @@ class OrcReader : public GenericReader {
std::string _get_field_name_lower_case(const orc::Type* orc_type, int pos);
+ void _collect_profile_on_close();
+
+private:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
**be/src/vec/exec/format/orc/vorc_reader.h:73:** previously declared here
```cpp
private:
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
