wangbo commented on code in PR #17414:
URL: https://github.com/apache/doris/pull/17414#discussion_r1125626948
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -742,6 +742,37 @@ public void replayBatchRemoveTransaction(List<Long>
txnIds) {
}
}
+ public void
replayBatchRemoveTransaction(BatchRemoveTransactionsOperationV2 operation) {
+ writeLock();
+ try {
+ int numOfClearedTransaction = 0;
+ if (operation.getLatestTxnIdForShort() != -1) {
+ while (!finalStatusTransactionStateDequeShort.isEmpty()) {
+ TransactionState transactionState =
finalStatusTransactionStateDequeShort.pop();
Review Comment:
In old version, when execute ```replayBatchRemoveTransaction```, txnId
could be removed when txnId locates in head of deque.
So in V2, how to ensure the consistency between
latestTxnIdForShort/latestTxnIdForLong and
finalStatusTransactionStateDequeShort/finalStatusTransactionStateDequeLong.
Is there the case that latestTxnIdForShort not in current
finalStatusTransactionStateDequeShort?
How about add a check here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
