[GitHub] [doris] Yulei-Yang commented on a diff in pull request #17342: [Improvement](meta) support return total statistics of all databases for command show proc '/jobs

[via GitHub]

Yulei-Yang commented on code in PR #17342:
URL: https://github.com/apache/doris/pull/17342#discussion_r1125614172


##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/LoadProcDir.java:
##########
@@ -57,18 +57,26 @@ public LoadProcDir(Load load, Database db) {
 
     @Override
     public ProcResult fetchResult() throws AnalysisException {
-        Preconditions.checkNotNull(db);
         Preconditions.checkNotNull(load);
 
         BaseProcResult result = new BaseProcResult();
         result.setNames(TITLE_NAMES);
 
         // merge load job from load and loadManager
-        LinkedList<List<Comparable>> loadJobInfos = 
load.getLoadJobInfosByDb(db.getId(), db.getFullName(),
+        LinkedList<List<Comparable>> loadJobInfos;
+
+        // db is null means need total result of all databases
+        if (db == null) {
+            loadJobInfos = load.getAllLoadJobInfos();

Review Comment:
   fix



##########
fe/fe-core/src/main/java/org/apache/doris/alter/AlterHandler.java:
##########
@@ -140,7 +142,20 @@ public Long 
getAlterJobV2Num(org.apache.doris.alter.AlterJobV2.JobState state, l
     }
 
     public Long getAlterJobV2Num(org.apache.doris.alter.AlterJobV2.JobState 
state) {
-        return alterJobsV2.values().stream().filter(e -> e.getJobState() == 
state).count();
+        Long counter = 0L;
+
+        for (AlterJobV2 job : alterJobsV2.values()) {

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org