zhangstar333 commented on code in PR #17344:
URL: https://github.com/apache/doris/pull/17344#discussion_r1125599437


##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -100,7 +104,7 @@
     [['element_at', '%element_extract%'], 'STRING', ['ARRAY_STRING', 
'BIGINT'], 'ALWAYS_NULLABLE'],
 
     # map element
-    [['element_at', '%element_extract%'], 'INT', ['MAP_STRING_INT', 'STRING'], 
'ALWAYS_NULLABLE'],
+    [['element_at', '%element_extract%'], 'V', ['MAP<K, V>', 'K'], 
'ALWAYS_NULLABLE', ['K', 'V']],
 

Review Comment:
   Great work! 
   is this could apply on some function like array_sort, which input arg is 
all_array type, and is same as return type.
   now we always register ARRAY_BOOLEAN........INT......., need more than 10 
functions.
   
   could be like this, only need one ?
   `[['array_sort'], 'ARRAY<K>',   ['ARRAY<K>'], ''],`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to