[GitHub] [doris] chenlinzhong commented on a diff in pull request #17362: [enhancement](stream load pipe) using queryid or load id to identify stream load pipe instead of fragment instance id

[via GitHub]

chenlinzhong commented on code in PR #17362:
URL: https://github.com/apache/doris/pull/17362#discussion_r1125389441


##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1405,6 +1402,7 @@ private void handleTransactionStmt() throws Exception {
                         
.append(context.getTxnEntry().getTxnConf().getTxnId()).append("'").append("}");
                 context.getState().setOk(0, 0, sb.toString());
             } catch (Exception e) {
+                LOG.warn("Txn commit failed", e);

Review Comment:
   LOG.warn("Txn commit failed, error={}", e.getMessage());



##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -623,10 +623,8 @@ public void execute(TUniqueId queryId) throws Exception {
             context.getState().setError(ErrorCode.ERR_UNKNOWN_ERROR, 
e.getMessage());
             throw e;
         } catch (UserException e) {
-            LOG.warn("", e);
             // analysis exception only print message, not print the stack
-            LOG.warn("execute Exception. {}, {}", context.getQueryIdentifier(),
-                                    e.getMessage());
+            LOG.warn("execute Exception. {}", context.getQueryIdentifier(), e);

Review Comment:
   why delete the execption message ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org