[GitHub] [doris] luozenglin commented on a diff in pull request #17298: [fix](array)(parquet) fix be core dump due to load from parquet file containing array types

[via GitHub]

luozenglin commented on code in PR #17298:
URL: https://github.com/apache/doris/pull/17298#discussion_r1124359660


##########
be/src/runtime/types.cpp:
##########
@@ -264,9 +264,9 @@ TypeDescriptor::TypeDescriptor(const 
google::protobuf::RepeatedPtrField<PTypeNod
     }
 }
 
-void TypeDescriptor::add_sub_type(TypeDescriptor&& sub_type, bool&& 
is_nullable) {
-    children.emplace_back(sub_type);
-    contains_nulls.emplace_back(is_nullable);
+void TypeDescriptor::add_sub_type(TypeDescriptor sub_type, bool is_nullable) {

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org